Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Enable scripting module #3754

Closed
wants to merge 1 commit into from
Closed

[BUGFIX] Enable scripting module #3754

wants to merge 1 commit into from

Conversation

jschlier
Copy link
Contributor

What this pr does

This PR fixes the Configuration for Solr by enabling the scripting module.
The XSLTResponseWriter is now part of this module and referenced later in the configuration.
Without enabling the scripting module Solr returns an error when trying to use the current configuration.

How to test

Create a new Solr core with the new configuration, which now no longer results in an error.

Fixes: #3753

@dkd-kaehm
Copy link
Collaborator

@jschlier Thanks for fixing that issue, please add a test case for core creation and deletion in main/Build/Test/cibuild_docker.sh

@dkd-kaehm
Copy link
Collaborator

@jschlier, @dkd-friedrich
Why this line does not do the same?

ext-solr/Resources/Private/Solr/solr.xml

Line 16 in 1b75d38

<str name="modules">scripting</str>

@jschlier
Copy link
Contributor Author

Ah, I did not see that. That might actually already fix this. I don't think I used this solr.xml configuration in my use case.

In fact I don't think we use this file at all in any of our projects, but install and set up Solr automatically using the Solr install script. Might be a misconfiguration on our end then with TYPO3 12. In that case we can simply close this pull request and issue.

The documentation says this:

As mentioned before the configSet is one single package, that contains all to customize a plain Apache Solr Server, to an Apache Solr Server, ready for EXT:solr & TYPO3.

But I guess that's not right then. The documentation is a bit contraditory, that might have confused me.

@jschlier jschlier closed this Aug 14, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Configset for Solr 9 is broken
2 participants
@jschlier @dkd-kaehm